From: shi (Shiv)

Subject: Series

Date: 1999-2-26 13:53


Hi,

Thanks to advice from Steve Haflich I was able to compile, load and test the
Series macro package on ACL4.3 (Solaris).  However tests 406 and 407 from
the file s-test.lisp failed.  If anyone can give me advice on fixing it, it
will be much appreciated.  Thanks,

--shiv--

--------------------More Info------------------------

I made the following changes to s-code.lisp to get it to compile

* changed compile-let to cltl1:compile-let
* changed special-form-p to cltl1:special-form-p

In addition I forced the creation of the SERIES package from the debugger as
it complains about creation from in-package (prefers defpackage).

The only warnings were about multiple definitions of alter-fn.

Loading was no trouble.

I also made changes to s-test.lisp.

* renamed the macro t to t-shiv and also all calls to the macro t with
  calls to the macro t-shiv
* changed 'float to 'short-float to avoid some warnings

I loaded the file without compiling it, and ran (do-tests).  Here is what I
got

2 out of 543 total tests failed: 406, 407.

The offending tests generated the following messages:

Test 406 failed
Form: (T-SHIV (LET ((L NIL) (X (GENERATOR (SCAN '(1 2 3 4)))))
                   (LOOP (PUSH (NEXT-IN X (RETURN NIL)) L)
                         (PUSH (NEXT-IN X (RETURN NIL)) L) (PUSH '+ L))
                   (NREVERSE L)))
Expected value: (1 2 + 3 4 +)
Actual value: ("opt and non-opt disagree" NIL (1 2 + 3 4 +)).
Test 407 failed
Form: (T-SHIV (LET ((L NIL) (X (GENERATOR (SCAN '(1 2 3 4)))))
                   (LOOP (PUSH (NEXT-IN X (NEXT-IN X (RETURN NIL))) L)
                         (PUSH (NEXT-IN X (RETURN NIL)) L) (PUSH '+ L))
                   (NREVERSE L)))
Expected value: (1 2 + 3 4 +)
Actual value: ("opt and non-opt disagree" NIL (1 2 + 3 4 +)).


As can be seen the opt versions returned nil rather than (1 2 + 3 4 +)

I also got several complaints of unused tags ...